D14666: Fixes memory leak in KUrlComboBox::setUrl

David Hallas noreply at phabricator.kde.org
Tue Aug 7 08:27:43 BST 2018


hallas created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Subject: Fixes memory leak in KUrlComboBox::setUrl
  
  Details:
  
  If setUrl is called multiple times it first removes the previous item
  but fails to delete the item before removing it causing a memory leak.

TEST PLAN
  Unit test

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14666

AFFECTED FILES
  autotests/kurlcomboboxtest.cpp
  autotests/kurlcomboboxtest.h
  src/widgets/kurlcombobox.cpp

To: hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180807/9494f149/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list