D14640: Use appropriate icon for a cancel button that will ask for a new name
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Aug 6 14:19:46 BST 2018
broulik added inline comments.
INLINE COMMENTS
> knewfilemenu.cpp:416
> KGuiItem cancelGuiItem(KStandardGuiItem::cancel());
> cancelGuiItem.setText(i18nc("@action:button", "Enter a different name"));
> + cancelGuiItem.setIcon(QIcon::fromTheme(QStringLiteral("edit-rename")));
Also this needs title capitalization [1]
[1] https://community.kde.org/KDE_Visual_Design_Group/HIG/Capitalization
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14640
To: ngraham, #frameworks, #vdg
Cc: broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180806/4bdb6d88/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list