D14162: Figure out the escaped path list on kconfig

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Aug 6 13:10:27 BST 2018


apol marked 3 inline comments as done.
apol added inline comments.

INLINE COMMENTS

> dfaure wrote in kconfiggroup.cpp:163
> I don't understand why this needs a vector. Isn't this only about consecutive backslashes?
> Wouldn't a counter be enough?

We're extracting the whole string and then removing the escapes, we need to remember them all.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14162

To: apol, #frameworks, dfaure
Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180806/016b82f4/attachment.html>


More information about the Kde-frameworks-devel mailing list