D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir marked 17 inline comments as done.
leinir added inline comments.

INLINE COMMENTS

> dfaure wrote in engine.cpp:133
> That's out of bounds, if tagFilter is empty!! It will assert.
> 
> You meant append or push_back, I think.

i did indeed!

> dfaure wrote in engine.cpp:138
> !? What's the point in clearing a list that is already empty?

None at all - that would be a bit of leftovers, thanks for spotting that :)

> cfeck wrote in khotnewstuff_test.knsrc.in:3
> Do we still need the kalzium references?

No, i guess we don't, really... gone :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180806/f1a59f37/attachment-0001.html>