D14218: Introduce a test to make sure we're not offering duplicated icons
David Faure
noreply at phabricator.kde.org
Mon Aug 6 08:36:40 BST 2018
dfaure added inline comments.
INLINE COMMENTS
> kiconloaderdummy.h:1
> +#ifndef KICONLOADERDUMMY_H
> +#define KICONLOADERDUMMY_H
copyright header missing
> kiconloaderdummy.h:9
> +#include <QSettings>
> +#include <QtTest>
> +
This includes all of QtTest *plus* all of QtCore. Prefer <QTest>
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14218
To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: dfaure, ngraham, andreask, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180806/11d9f2be/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list