D14449: Modify device usage information
Henrik Fehlauer
noreply at phabricator.kde.org
Sun Aug 5 23:42:45 BST 2018
rkflx added a comment.
In D14449#303766 <https://phabricator.kde.org/D14449#303766>, @shubham wrote:
> In D14449#300327 <https://phabricator.kde.org/D14449#300327>, @ngraham wrote:
>
> > +1 for using the same label but putting the information on more than one line like @rkflx suggests.
>
As far as I can see that comment was part of the discussion about what to show, which I think we now concluded. I don't think that was meant as an advice regarding implementation.
You are already creating a new label (which is fine, also where you're doing it is the perfect spot). I was only wondering whether the call to `setText` should better be placed elsewhere.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14449
To: shubham, ngraham, #frameworks, rkflx
Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180805/f7b87f07/attachment.html>
More information about the Kde-frameworks-devel
mailing list