D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

David Faure noreply at phabricator.kde.org
Sun Aug 5 21:51:22 BST 2018


dfaure added a comment.


  Hmm, well, for IconApplet's use case, if you never want a readonly line-edit then a major redesign is needed, switching from the lineedit to the qlabel inside of setFileNameReadOnly itself...
  (and using that in the code modified by this patch...). Or adding a ctor flag, to avoid creating+destroying widgets right away...
  Given the number of iterations just to get the simple case right, let's do that separately, ok? I could do it myself, faster than doing 10 reviews :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14610

To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180805/c8834a18/attachment.html>


More information about the Kde-frameworks-devel mailing list