D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

[Henrik Fehlauer]

rkflx added a comment.


  @shubham Thanks for helping out with T9297 <https://phabricator.kde.org/T9297>!
  
  > reuse the above code that creates a QLabel
  
  @dfaure Thanks for the review! Any advice on how to handle `KPropertiesDialog::setFileNameReadOnly`, which is used in Plasma's `IconApplet` <https://lxr.kde.org/source/kde/workspace/plasma-workspace/applets/icon/iconapplet.cpp#0528> and would still show the `KLineEdit` if I understand your proposal correctly?
  
  Also, `KFilePropsPlugin::setFileNameReadOnly` checks for `m_bFromTemplate`. Would this be relevant for your suggestion too?
  
  > the patch description is unclear
  
  The main motivation for the patch is to also indicate visually that an item's name cannot be changed. Currently users only notice that by chance due to typing into the line edit not being allowed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14610

To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180804/dd96ca5f/attachment.html>