D14565: Fix overflow in rounding code

Sune Vuorela noreply at phabricator.kde.org
Fri Aug 3 16:44:52 BST 2018


svuorela added a comment.


  In D14565#302581 <https://phabricator.kde.org/D14565#302581>, @cfeck wrote:
  
  > In D14565#302551 <https://phabricator.kde.org/D14565#302551>, @safaalfulaij wrote:
  >
  > > Maybe you should use `largeValue` instead of `largevalue`.
  >
  >
  > Yes, that would be consistent with what we do elsewhere.
  
  
  Done.
  
  > I had hoped a junior would grab this ticket before a senior ruins the show (insert emoticon here), but having a fast fix for 5.49.0 is surely also nice.
  
  I was considering leaving it for another week or two, but then I would probably have forgotten about it.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14565

To: svuorela, cfeck, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180803/d4995164/attachment.html>


More information about the Kde-frameworks-devel mailing list