D14565: Fix overflow in rounding code
Christoph Feck
noreply at phabricator.kde.org
Thu Aug 2 22:37:39 BST 2018
cfeck requested changes to this revision.
cfeck added a comment.
This revision now requires changes to proceed.
In D14565#302551 <https://phabricator.kde.org/D14565#302551>, @safaalfulaij wrote:
> Maybe you should use `largeValue` instead of `largevalue`.
Yes, that would be consistent with what we do elsewhere.
I had hoped a junior would grab this ticket before a senior ruins the show (insert emoticon here), but having a fast fix for 5.49.0 is surely also nice.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D14565
To: svuorela, cfeck, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180802/a345bbe1/attachment.html>
More information about the Kde-frameworks-devel
mailing list