D12235: Add XDG Output Protocol

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> romangg wrote in xdgoutput_interface.cpp:83
> This variable is only relevant until the compositor has sent for the first time the done event via `XdgOutputInterface::done()`. Afterwards it is always true. Is it meant this way? If yes, could we use another name making this fact more explicit, like: `doneOnce`?
> 
> On the other side what if a compositor never sends the done event via `XdgOutputInterface::done()` because the xdg output never changes its logical size or position after the compositor publishes the xdg output to clients and it expects clients to receive the current values on connecting to the resource?

> If yes, could we use another name making this fact more explicit, like: doneOnce?

It is. I can make that change

> On the other side what if a compositor never sends the done event via

It should be set on creation. If it's not the compositor is doing things wrong.  I can update the docs to make it clear

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12235

To: davidedmundson, romangg
Cc: #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180430/29eabe47/attachment.html>