D12590: KFileWidget: Disable zoom buttons once reached minimum or maximum

Nathaniel Graham noreply at phabricator.kde.org
Mon Apr 30 03:20:46 UTC 2018


ngraham added a comment.


  Looks and works great; just one style comment below:

INLINE COMMENTS

> kfilewidget.cpp:108
> +          iconSizeSlider(nullptr),
> +          furtherAction(nullptr),
> +          closerAction(nullptr)

While we're at it, why don't we rename these to be clearer: I'd prefer `zoomInAction` and `zoomOutAction`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12590

To: rkflx, #frameworks
Cc: ngraham, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180430/00fef5fa/attachment.html>


More information about the Kde-frameworks-devel mailing list