D12544: Don't select file extension
Elvis Angelaccio
noreply at phabricator.kde.org
Sun Apr 29 13:58:32 UTC 2018
elvisangelaccio added inline comments.
INLINE COMMENTS
> kfilewidget.cpp:1290
>
> // don't change selection when user has clicked on an item
> + if (operationMode == KFileWidget::Saving) {
This comment makes little sense to me. Since it was part of the same commit spotted by @rkflx (0134fb3a5e50 <https://phabricator.kde.org/R446:0134fb3a5e507737d3ebc1ca8db7b0b1509d5e2c>), I'd just remove it.
> kfilewidget.cpp:1330
>
> // don't change selection when user has clicked on an item
> + if (operationMode == KFileWidget::Saving) {
Same for this comment.
REPOSITORY
R241 KIO
BRANCH
select_filename_only (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12544
To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: elvisangelaccio, rkflx, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180429/9aebb485/attachment.html>
More information about the Kde-frameworks-devel
mailing list