D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I liked more the version with two newlines before the bold sentence, is there a reason why you changed to only one?

INLINE COMMENTS

> jobuidelegate.cpp:239
>                           widget,
> -                         i18nc("@info", "Do you want to permanently delete all items from Trash? This action cannot be undone."),
> +                         xi18nc("@info", "Do you want to permanently delete all items from Trash?<nl><emphasis strong='true'>This action cannot be undone.</emphasis>"),
>                           QString(),

There is a missing slash in the `<nl>` tag.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12420

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: broulik, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180429/10308057/attachment.html>