D12594: KFileWidget: Perfectly align filename widget with icon view

[Henrik Fehlauer]

rkflx created this revision.
rkflx added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
rkflx requested review of this revision.

REVISION SUMMARY
  Since the redesign of the file dialog for KDE4, the left edges of the
  line edits below the icon view were supposed to be aligned to the left
  edge of the icon view, while in KDE3 the naming labels were aligned
  instead.
  
  However, in practice that never worked out perfectly, there was always a
  small displacement. While hardly noticable in KDE4's widget styles, in
  particular for Breeze in KF5 with its small splitter handle width and
  larger layout spacing this became much more annoying to look at.
  
  This can be fixed by taking the splitter handle width as well as the
  grid layout spacing into account. While the patch seems straightforward,
  making the patch work with all styles was actually suprisingly
  difficult, not only because of the bug in the dependent patch.
  
  Depends on D12592 <https://phabricator.kde.org/D12592>
  
  Ref T8552 <https://phabricator.kde.org/T8552>
  
  FIXED-IN: 5.46

TEST PLAN
  `kdialog --getopenfilename`, check alignment with KMag for
  different widget styles (e.g. Breeze, Oxygen, Windows and Fusion) after
  startup, and after moving the splitter, resizing the dialog and toggling
  the places panel.
  
  Before:
  F5826739: KIO-alignment-before.png <https://phabricator.kde.org/F5826739>
  
  After:
  F5826740: KIO-alignment-after.png <https://phabricator.kde.org/F5826740>

REPOSITORY
  R241 KIO

BRANCH
  fix-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12594

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: rkflx, #frameworks
Cc: michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180429/d6ce568c/attachment.html>