D12593: KFileWidget: Save places panel width also after hiding panel

Henrik Fehlauer noreply at phabricator.kde.org
Sun Apr 29 06:12:25 UTC 2018


rkflx created this revision.
rkflx added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
rkflx requested review of this revision.

REVISION SUMMARY
  In certain situations the user-set width of the places panel was not
  remembered.
  
  As `placesViewWidth` is initialized by `configGroup.readEntry` and
  updated in reaction to user actions, it makes sense to also save the
  same variable back to the config file, instead of looking directly at
  the `placesViewSplitter`.
  
  Depends on D12592 <https://phabricator.kde.org/D12592>
  
  Ref T8552 <https://phabricator.kde.org/T8552>
  
  FIXED-IN: 5.46

TEST PLAN
  `kdialog --getopenfilename`, change width of places panel, hide places
  panel with [F9], close dialog by clicking on Cancel, reopen
  dialog, close dialog a second time, reopen dialog, press [F9] again
  and check that previously set width is restored.

REPOSITORY
  R241 KIO

BRANCH
  fix-hidden-places-width-saving (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12593

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: rkflx, #frameworks
Cc: michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180429/7d253a80/attachment.html>


More information about the Kde-frameworks-devel mailing list