D12538: Always prompt for overwrite on double-click in save dialog

[Henrik Fehlauer]

rkflx added a comment.


  TBH, I don't get what the overwrite and release schedule discussion has to do with this patch. All it does is add an additional method to trigger `slotOk()`, i.e. instead of clicking on Save, users can simply double-click.
  
  The fact that either the dialog or the app ask before overwriting in response to the slot is not changed in any way here. Don't judge a Diff by its title, in particular as long as the request to "Please update your summary too" is still in state "red" ;)
  
  ---
  
  Regarding what you were discussing: If I understood Peter's analysis in D12346 <https://phabricator.kde.org/D12346> correctly, the API will always allow apps to opt-out of the dialog providing the overwrite confirmation, and instead add their own. Therefore to me it seems like it is only a matter of going through all apps and opt-in to the already existing functionality, i.e. I don't see why this would require changes in KIO which would result in dependency issues (unless I'm mistaken?).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: ltoscano, rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180428/70a027c0/attachment.html>