D12371: fix always reproducible crash
David Faure
noreply at phabricator.kde.org
Sat Apr 28 13:59:01 UTC 2018
dfaure added a comment.
"I'm redirected to fish://127.0.0.1/home/jtorres" is exactly what is supposed to happen. If that asserts nowadays, it means there's a regression in the redirect handling. Sounds like this has to be fixed first.
QUrl::toString is slowish btw, it has to assemble the string from the multiple components of the URLs. Just to test the path, it's overkill.
Anyhow, "if (!u.path().isEmpty()) " is what makes sense, we "just" have to fix redirection handling too (I can take a look tomorrow, I have to leave soon today)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D12371
To: jtamate, dfaure, #frameworks, apol
Cc: anthonyfieroni, apol, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180428/8978a87c/attachment.html>
More information about the Kde-frameworks-devel
mailing list