D12508: Make KMessageWidget match Kirigami inlineMessage's style

Joshua Noack noreply at phabricator.kde.org
Sat Apr 28 11:03:27 UTC 2018


jnoack added a comment.


  Imo KMessageWidget should not rely on being placed where there's enough contrast. The transparency just doesn't work in the case of Konsole.
  Either Konsole needs to move the widget outside the terminal painting area which looks complicated to achieve or the message widget should provide some API
  which apps can use in cases where the background has not enough contrast.
  
  In D12508#253854 <https://phabricator.kde.org/D12508#253854>, @cfeck wrote:
  
  > Regarding the Konsole isse, it may not be the only application expecting a window background. Maybe some autoFillBackground helps, see http://doc.qt.io/qt-5/qwidget.html#autoFillBackground-prop
  
  
  I just tried setting autoFillBackground: The background is not animated, so it breaks the animation of the message widget. Also it is painted black. I guess those things could be fixed within the KMessageWidget.
  
  The question is what makes more sense, fixing each application where the message widget looks broken or fixing the message widget to look not broken. 🤔

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12508

To: ngraham, hein, #plasma, #vdg, elvisangelaccio, cfeck
Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180428/2820447e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list