D12328: Enable preview by default in the filepicker dialog

Henrik Fehlauer noreply at phabricator.kde.org
Thu Apr 26 20:15:22 UTC 2018


rkflx accepted this revision.
rkflx added a subscriber: elvisangelaccio.
rkflx added a comment.
This revision is now accepted and ready to land.


  LGTM now (even though you ignored the "newline" I suggested…)
  
  I'd appreciate a second opinion from #Frameworks <https://phabricator.kde.org/tag/frameworks/> on the new `kconf_update` directory, though.
  
  Also, the very idea of enabling previews by default in the file picker (as was done in Dolphin for 18.04) should get some more buy-in. I feel bad for tagging @elvisangelaccio again, but maybe you have suggestions for someone else who might help out in reviewing some of the patches for the file dialog?

BRANCH
  preview_default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12328

To: anemeth, #frameworks, #vdg, rkflx
Cc: elvisangelaccio, abetts, rkflx, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180426/624c5366/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list