D12545: Set focus on the filename line edit when a file is selected

[Henrik Fehlauer]

rkflx requested changes to this revision.
rkflx added a comment.


  Hm, this breaks selecting files and even navigating directories with the keyboard (e.g. via the arrow keys), and as such cannot possibly be something we want.
  
  I could imagine a different spin here: [⇥] should switch focus from the item view to the name line edit, which it currently does not. (And as the dialog starts with focus on the name line edit, [⇧] + [⇥] should switch focus immediately to the item view.)
  
  Probably needs proper tabstop ordering.
  
  ---
  
  In D12545#254437 <https://phabricator.kde.org/D12545#254437>, @ngraham wrote:
  
  > This is clearly what the code was //trying// to do, based on inline comments: https://cgit.kde.org/kio.git/tree/src/filewidgets/kfilewidget.cpp#n1176
  
  
  From observing the behaviour, to me this seems to affect the save dialog, and only upon //clicking// on a file. When navigating via the keyboard and thus merely //selecting// a file, this does not seem to be called. IOW, this part of the code seems fine to me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180426/877990b6/attachment.html>