D12336: Replace several Q_ASSERTs with proper checks

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> documenturldb.cpp:107
>  {
> -    Q_ASSERT(id > 0);
> -    Q_ASSERT(!name.isEmpty());
> +    if (!docId || name.isEmpty()) {
> +        return;

Didn't you mean `id`?

> documenturldb.cpp:172
>  {
> -    Q_ASSERT(docId > 0);
> +    if (newFileName.isEmpty() || !docId) {
> +        return;

Put `docId` check first for consistency

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12336

To: bruns, #baloo, michaelh, #frameworks
Cc: broulik, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180426/f20833b8/attachment.html>