D12321: Hide file preview when icon is too small

[Henrik Fehlauer]

rkflx added a comment.


  Thanks. Still not 100% there, though ;) (And please rebase on current master, while you are at it…)

INLINE COMMENTS

> kdiroperator.cpp:2622
>      } else {
> -        const QFontMetrics metrics(itemView->viewport()->font());
> +        const QFontMetrics metrics(itemView->viewport()->font());        
>          int size = itemView->iconSize().height() + metrics.height() * 2;

You still got an unrelated whitespace change here (check on Phabricator with Revision Contents > History > Whitespace Changes > Show All).

> kdiroperator.cpp:2166
>          d->showPreviews = configGroup.readEntry(QStringLiteral("Previews"), false);
> +        d->showPreviewsEnabledBeforeZoom = d->showPreviews;
>      }

Don't remove that, otherwise your reviewer will be totally confused and wonder why your patch is suddenly totally broken! :D

(I suspect you already removed what Nate wanted in an earlier revision, but the rest should be kept, of course…)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg
Cc: markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180425/9c040fe2/attachment.html>