D12321: Hide file preview when icon is too small

Alex Nemeth noreply at phabricator.kde.org
Wed Apr 25 19:28:54 UTC 2018


anemeth marked an inline comment as done.
anemeth added inline comments.

INLINE COMMENTS

> rkflx wrote in kdiroperator.cpp:2589-2591
> Could you explain why you need to change `showPreviewsEnabledBeforeZoom` here? As far as I can see this variable just caches the config value, and thus should only be set in `_k_toggleInlinePreviews`?
> 
> Do you have an example where something would break if we would remove this code block?

Without this the previews are always disabled when opening the dialog. This was added to enable it and then disable it right after if the read config was disabled in the `k_toggleInlinePreviews` function.
This will be fixed with D12328 <https://phabricator.kde.org/D12328>

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg
Cc: markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180425/3e94d2e4/attachment.html>


More information about the Kde-frameworks-devel mailing list