D12508: Make KMessageWidget match Kirigami inlineMessage's style

Christoph Feck noreply at phabricator.kde.org
Wed Apr 25 15:44:30 UTC 2018


cfeck requested changes to this revision.
cfeck added a comment.
This revision now requires changes to proceed.


  The gradient was a remnant from the Oxygen days. Glad that it's gone.
  
  Could you please restore the comments that state where the colors were taken from?

INLINE COMMENTS

> kmessagewidget.cpp:286
> +    // Adjust the background color to match the Kirigami InlineMessage
> +    bg.setAlpha(51); // == 20% opacity (255 * 0.2 = 51)
>  

If you use setAlphaF(0.2) you don't need to explain the value.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12508

To: ngraham, hein, #plasma, #vdg, elvisangelaccio, cfeck
Cc: cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180425/c91a5145/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list