D12518: [Button Styles] Fill height and vertical align

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Apr 25 14:11:37 UTC 2018


broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise the `Text` will never grow below its preferred height as the button grows smaller and will eventually leak outside at the bottom rather than stay centered.
  
  BUG: 393388

TEST PLAN
  Regression caused by D11557 <https://phabricator.kde.org/D11557>
  
  - Global menu buttons are vertically aligned correctly in a narrow panel again
  - Other buttons looked fine

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12518

AFFECTED FILES
  src/declarativeimports/plasmastyle/ButtonStyle.qml
  src/declarativeimports/plasmastyle/ToolButtonStyle.qml

To: broulik, #plasma
Cc: #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180425/6fb46975/attachment.html>


More information about the Kde-frameworks-devel mailing list