D12508: Make KMessageWidget match Kirigami inlineMessage's style
Nathaniel Graham
noreply at phabricator.kde.org
Wed Apr 25 02:55:03 UTC 2018
ngraham created this revision.
ngraham added reviewers: hein, Plasma, VDG.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
ngraham requested review of this revision.
REVISION SUMMARY
This patch makes the venerable and wonderful `KMessageWidget` match the slick style of Kirigami's new `inlineMessage` control. As a by-product, it correctly takes colors from the user's theme and fixes a few usability bugs.
BUG: 385299
BUG: 381255
TEST PLAN
Spectacle, Breeze light, information:
Spectable, Breeze light, positive:
Dolphin, Breeze dark: warning:
Konsole, light, warning:
Oops, doesn't work! We'll need to fix Konsole to put a proper background behind it rather than overlapping the content.
Style comparison between KMessageWidget and inlineMessage:
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12508
AFFECTED FILES
CMakeLists.txt
src/CMakeLists.txt
src/kmessagewidget.cpp
To: ngraham, hein, #plasma, #vdg
Cc: #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180425/695c881b/attachment.html>
More information about the Kde-frameworks-devel
mailing list