D12490: concatPaths: process empty path1 correctly

[Алексей Шилин]

aleksejshilin added a comment.


  In D12490#252959 <https://phabricator.kde.org/D12490#252959>, @anthonyfieroni wrote:
  
  > path1 *should* never be empty
  
  
  Hm... I thought concatPaths() is supposed to be used like this: `concatPaths(basePath, relativePath)` - then an empty basePath makes sense (and means 'current directory'). If this is not the case, then:
  
  - KUrlCompletion (and probably KCompletion) needs to be fixed;
  - `Q_ASSERT(!path1.isEmpty())` should be added here so that such bugs get noticed.
  
  Is this correct?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12490

To: aleksejshilin, #frameworks, anthonyfieroni, dfaure
Cc: michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180424/ada7240f/attachment.html>