D10078: Add separate lib KF5::DBusRunner

David Edmundson noreply at phabricator.kde.org
Mon Apr 23 21:49:49 UTC 2018


davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> abstractrunner_p.h:46
> +
> +    void cancelMatching(const RunnerContext::Ptr &context);
> +    void finishMatching(const RunnerContext::Ptr &context);

This undermines the advantages of my changes. 
Its not object oriented anymore.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D10078

To: kossebau, broulik, davidedmundson
Cc: bruns, michaelh, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180423/09d19d3c/attachment.html>


More information about the Kde-frameworks-devel mailing list