D11925: Add "SkipSwitcher" to API

Martin Flöser noreply at phabricator.kde.org
Mon Apr 23 19:47:09 UTC 2018


graesslin added a comment.


  There is one more file which need changes. In src/client/registry.cpp you need to increase the version numbers of the two changed protocols. Adding a new request can be really cumbersome.

INLINE COMMENTS

> plasmashell_interface.cpp:53
>  
>  const quint32 PlasmaShellInterface::Private::s_version = 4;
>  

you need to increase the version number.

> plasmashell_interface.cpp:168
>      setSkipTaskbarCallback,
> +    setSkipSwitcherCallback,
>      panelAutoHideHideCallback,

This is at the wrong position. It needs to be the last entry in the list. That might be your compile problem you mentioned in the KWin request.

> plasmawindowmanagement_interface.cpp:122
>  
>  const quint32 PlasmaWindowManagementInterface::Private::s_version = 7;
>  

you need to increase the version number.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180423/a12fea39/attachment.html>


More information about the Kde-frameworks-devel mailing list