D12321: Hide file preview when icon is too small

[Mark Gaiser]

markg added a comment.


  In D12321#252346 <https://phabricator.kde.org/D12321#252346>, @ngraham wrote:
  
  > In D12321#252337 <https://phabricator.kde.org/D12321#252337>, @markg wrote:
  >
  > > In D12321#252299 <https://phabricator.kde.org/D12321#252299>, @rkflx wrote:
  > >
  > > > > Then you make it impossible (ultimately, not with this patch though) to for instance browse through folders with small icons (say icon sets).
  > > >
  > > > We have an explicit icon chooser dialog for this task, using the file dialog is not the recommended way for apps to select an icon. Also, as you may have noticed, the file dialog does not show previews of SVGs for any size, making your point moot.
  > > >
  > > > As for choosing PNG icons, you can simply set the icon size large enough (38px for me) to see the previews anyway. This workaround is good enough, and should not prevent us from improving the handling for all other situations. Let's be honest here: How often do you want to select icons with <38px size, but cannot increase the size temporarily?
  > >
  > >
  > > I think you mis-interpreted what i said which then caused @ngraham to reply with apparently that in mind which is also not as i intended :)
  > >
  > > I intended specifically what i said.
  > >  **browse** a folder with lots of icons **like** an icon pack/theme. And yes, that is - sometimes - very handy to have!
  > >  I said nothing about the view mode (i meant the grid view though, not the list view).
  >
  >
  > Browse... grid view... small size... previews... icons... so you want to be able to do this?
  >
  > F5819296: Small, not useful.png <https://phabricator.kde.org/F5819296>
  
  
  Sometimes, yes.
  Like when looking for which icon to use for another button in the application i'm making for my job for instance....

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg
Cc: markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180423/97f78d10/attachment.html>