D12448: Fix KCompletionBox on wayland

[Aleix Pol Gonzalez]

apol added a comment.


  In D12448#251908 <https://phabricator.kde.org/D12448#251908>, @anthonyfieroni wrote:
  
  > Why not
  >
  >   static const auto flags = qGuiApp->platformName() == QLatin1String("wayland") ? Qt::WindowFlags(Qt::ToolTip | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint) :
  >                                                                                   Qt::WindowFlags(Qt::Window | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint);
  >   q->setWindowFlags(flags);
  >
  >
  > It's not need to check in every completion construction.
  
  
  It's not blocking or anything, I don't see a reason to cache the value.

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12448

To: apol, #frameworks, davidedmundson
Cc: anthonyfieroni, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180422/852cf7f5/attachment.html>