D12228: kdirlister new connect syntax

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Looks good, but shouldn't you remove the Q_PRIVATE_SLOT declarations too? They aren't used anymore, AFAICS.

INLINE COMMENTS

> kcoredirlister.cpp:2720
> +    m_parent->connect(job, &KJob::infoMessage, m_parent,
> +        [this](KJob *job,const QString &plain){ _k_slotInfoMessage(job, plain); });
> +    m_parent->connect(job, QOverload<KJob*, ulong>::of(&KJob::percent), m_parent,

missing space after the first comma

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12228

To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180420/d646bb60/attachment.html>