D12380: [Containment Interface] Honor plasma/containment_context_menu restriction

[Harald Sitter]

sitter requested changes to this revision.
sitter added a comment.
This revision now requires changes to proceed.


  quick dump from irc
  
    [14:48] <sitter> kbroulik: hm, doesn't mousePressEvent get called for all clicks? (i.e. original line 1021-2026 are where the call chain goes into addContainmentActions whcih is where containment_actions is checked), so this implementation would make containment_context_menu=false imply containment_actions=false, no?
    [14:49] <kbroulik> kinda
    [14:49] <kbroulik> but you can also restrict just containment ations without context menu
    [14:49] <kbroulik> oh fuck this shit :(
    [14:50] <sitter> but not vice versa (:
    [14:50] <sitter> I'd think they are orthogonal from the documentation
    [14:50] <sitter> i.e. as previously mentioned one is disable-left/middle-click the other is disable-right-click
    [14:51] <kbroulik> so containment_actions should do what my patch doies
    [14:51] <kbroulik> and containment_context_menu should burn in hell
    [14:51] <sitter> I'd be content with that :)
  
  Or easier to parse perhaps: either `containment_context_menu` and `containment_actions` should be orthogonal (applying to right-click and all-other-clicks respectively) OR `containment_actions` applies to all clicks while `containment_context_menu` only applies to context menu clicks (right clicks) as suggested by Kai.
  
  Previous documentation on the two is as follows:
  
    ;plasma/containment_actions (since Plasma 4.4)
    :Whether or not to allow Plasma mouse actions on containments (usually menus that pop up on mouse clicks).
    
    ;plasma/containment_context_menu (4.4)
    :Whether a context menu should be shown on containments; this can be used to shut off the desktop context menu in plasma-desktop, for instance.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12380

To: broulik, #plasma, sitter
Cc: #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180420/98cdd961/attachment.html>