D12371: fix always reproducible crash
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Fri Apr 20 09:27:45 UTC 2018
apol added inline comments.
INLINE COMMENTS
> kdirmodel.cpp:401
> {
> + // dirLister is probably onwed by KCoreDirListerCache
> if (d->m_dirLister) {
Maybe KCoreDirListerCache should be using a QPointer? or checking if it gets deleted?
> kdirmodel.h:65
> */
> + // Can't take ownership because KCoreDirListerCache is probably the owner.
> void setDirLister(KDirLister *dirLister);
It's a bit weird having a comment after a comment.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D12371
To: jtamate, dfaure, #frameworks
Cc: apol, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180420/23585c92/attachment.html>
More information about the Kde-frameworks-devel
mailing list