D12197: autotests: Test for multiple values

[Michael Heidelbach]

michaelh requested review of this revision.
michaelh marked an inline comment as done.
michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in multivaluetest.cpp:91
> Again, I prefer this notation versus `expectedresult`
> You can make this somewhat shorter by using  `QVariantList{QStringLiteral{"Baloo KFileMetaData"}}`, i.e. omit the extra `QVariant`

I want defend `expectedresult` a little. The background: `testXXX_data` functions tend to be very long and it is easy (for me) to get confused about what is tested against which value. `expectedresult` tries to make clear that it is always the same value.
If you can't/don't agree with that. I'll follow your lead :-)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12197

To: michaelh, #baloo, #frameworks, mgallien, bruns
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180419/0ab10381/attachment.html>