D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size
Nathaniel Graham
noreply at phabricator.kde.org
Wed Apr 18 19:54:20 UTC 2018
ngraham added inline comments.
INLINE COMMENTS
> anemeth wrote in kdiroperator.cpp:2605
> What is the relation between 43 and 64px?
> Does this hardcoded number also work when scaled?
The number is a 0-100 scale, with 0 corresponding to 16px, and 100 corresponding to 128px, and all other numbers corresponding to in-between sized along that same linear scale. It's a bit odd, and not the way I would have implemented it, but that's what we've got, so I decided to work with it and just add comments to improve the comprehensibility.
And yeah, it works fine with a HiDPI scale factor.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D12326
To: ngraham
Cc: anemeth, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180418/ad163705/attachment.html>
More information about the Kde-frameworks-devel
mailing list