D12306: Filepicker dialog proper grid icon layout

[Henrik Fehlauer]

rkflx added a comment.


  Cool! Can you also tweak the vertical spacing a bit? Currently Nate displays 2 rows of text (left), while your patch shows 3 (right), resulting in fewer items visible at once. Of course the best course of action would be to make this adapt dynamically to the filename like in Dolphin, but if that is too complicated for now, I think we should go with 2 rows, because that seems to fit most situations:
  
  F5811757: KIO-vertical-spacing.png <https://phabricator.kde.org/F5811757>
  
  ---
  
  One more thing:
  
  In D10672#209864 <https://phabricator.kde.org/D10672#209864>, @rkflx wrote:
  
  > Do you plan to submit more patches to KDE in the coming months?
  
  
  
  
  In D10672#209876 <https://phabricator.kde.org/D10672#209876>, @anemeth wrote:
  
  > @rkflx I'm not sure...
  
  
  I think you should definitely think about applying for a developer account <https://community.kde.org/Infrastructure/Get_a_Developer_Account> ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg
Cc: rkflx, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180418/9cc6f80e/attachment.html>