D12306: Filepicker dialog proper grid icon layout

[Henrik Fehlauer]

rkflx added subscribers: ngraham, rkflx.
rkflx added a comment.


  Nice! Make sure to talk to @ngraham in D12149: Improve grid spacing in icons-on-top mode for open/save dialogs <https://phabricator.kde.org/D12149>, where he worked on something similar (but also set a larger text width for small icons). We might want to pick parts from both patches, but currently they are conflicting.
  
  However, there is one way I immediately could break your patch. Set a very large icon size, then move the places splitter all the way to the right:
  
    Floating point exception (core dumped)

INLINE COMMENTS

> kdiroperator.cpp:2595
> +        const int remainingWidth = viewPortWidth - (height * itemsInRow);
> +        const int width = height + (remainingWidth / itemsInRow);
> +

Thread 1 "kdialog" received signal SIGFPE, Arithmetic exception.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg
Cc: rkflx, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180418/36c99334/attachment-0001.html>