D12222: baloodb: Use complete access filtering for all outputs

Michael Heidelbach noreply at phabricator.kde.org
Tue Apr 17 20:51:10 UTC 2018


michaelh marked an inline comment as done.
michaelh added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:196
> +                              summary.accessible += (info.deviceId == deviceId && info.accessible ? 1 : 0);
> +                              return info.deviceId == deviceId;
> +                          });

~3 hrs for this, phew.

> michaelh wrote in databasesanitizer.cpp:160
>   $ baloodb list --mounted-only Einstein
>   Listing database contents...
>   ! device: 43 inode: 319 url: /media/circulans/(tv-analog)/L-Z/Was Einstein noch nicht wusste.mkv
>   + device: 46 inode: 319 url: /media/circulans/(doku)/Was Einstein noch nicht wusste.mkv
> 
> 43 is the correct id for a share. The path is wrong.
> 46 is a wrong id for the same share. It should not be listed. The path however is correct.
> 
> `QStorageInfo` is not enough, I'm afraid. For proper matching mtab must be read.

On the wrong track

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12222

To: michaelh, #baloo, #frameworks
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180417/e6395c7e/attachment.html>


More information about the Kde-frameworks-devel mailing list