D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

[Nathaniel Graham]

ngraham marked 2 inline comments as done.
ngraham added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kdeplatformfiledialoghelper.cpp:108
> Even better to me should be
> 
>   connect(this, &KDEPlatformFileDialog::rejected, m_fileWidget, &KFileWidget::slotCancel);
> 
> PS: You can make a different review to change old syntax (SIGNAL/SLOT) to new function pointers.

Sounds good, I will do that after this!

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D12240

To: ngraham, #frameworks
Cc: anthonyfieroni, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180417/7a5703a7/attachment.html>