D12222: baloodb: Use complete access filtering for all outputs
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Mon Apr 16 22:43:08 UTC 2018
bruns added inline comments.
INLINE COMMENTS
> databasesanitizer.cpp:179
> + tail = std::remove_if(infos.begin(), tail,
> + [deviceId,&summary] (const FileInfo& info) {
> + summary.accessible += info.accessible;
missing space
> databasesanitizer.cpp:180
> + [deviceId,&summary] (const FileInfo& info) {
> + summary.accessible += info.accessible;
> + return info.id == deviceId;
bool is automatically cast to int, false -> 0, true -> 1.
Although probably better to do it explicitly:
`summary.accessible += info.accessible ? 1 : 0;`
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D12222
To: michaelh, #baloo, #frameworks
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180416/b3e80817/attachment.html>
More information about the Kde-frameworks-devel
mailing list