D11753: baloodb: Add clean command

Michael Heidelbach noreply at phabricator.kde.org
Mon Apr 16 19:13:07 UTC 2018


michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in databasesanitizer.cpp:173
> Pass in a List/Set of deviceIds, and return the same type.

Your suggestion in D12222 <https://phabricator.kde.org/D12222> can be reused. I'll do it there.

> bruns wrote in databasesanitizer.cpp:187
> Are you planning to use this one anywhere else?
> 
> Otherwise, inside `deviceFilters(...)`:
> 
>   auto isIgnored = [&accessFilter](const QStorageInfo& storageInfo) {
>       if (storageInfo.isValid() && ...) {
>           ...
>       }
>   }

> Are you planning to use this one anywhere else?

Yes. For all output: D12222 <https://phabricator.kde.org/D12222>

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks, bruns
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180416/cb2e7a2c/attachment.html>


More information about the Kde-frameworks-devel mailing list