D12233: Avoid manipulation of lists with quadratic complexity
Michael Heidelbach
noreply at phabricator.kde.org
Sun Apr 15 20:43:45 UTC 2018
michaelh created this revision.
michaelh added a reviewer: Baloo.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
michaelh requested review of this revision.
REVISION SUMMARY
When removing items from lists Baloo uses an implementation with quadratic complexity: O(m*n) m: removed items, n: items in list.
Use `std::remove_if` and `erase` instead.
TEST PLAN
make test
REPOSITORY
R293 Baloo
BRANCH
remove-if (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12233
AFFECTED FILES
src/file/fileindexscheduler.cpp
src/file/pendingfilequeue.cpp
To: michaelh, #baloo
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180415/e361cd6b/attachment.html>
More information about the Kde-frameworks-devel
mailing list