D12227: Save the dialog view settings even when canceling

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, for file Open & Save dialogs, any view settings you've changed are only remembered if you actually open or save the file; they're ignored if you cancel the dialog using the Cancel button. This patch fixes that, since there's no particular reason why a user should want to discard any view changes just because they decided not to open or save the file.
  
  BUG: 209559
  FIXED-IN: 5.46

TEST PLAN
  Open a file open or save dialog, change the view, hit the cancel button, then open it again.
  
  Note: this patch does //not// fix the case of the view not being saved when closing the dialog via the [⎋] key or the titlebar close button; those cases need to be separately handled in the QPA theme plugin, which actually creates the dialog window.

REPOSITORY
  R241 KIO

BRANCH
  save-dialog-view-settings-on-cancel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12227

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks
Cc: michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180415/2214a0b0/attachment.html>