D12218: Remove Reload button from the file dialogs' toolbar

Nathaniel Graham noreply at phabricator.kde.org
Sun Apr 15 04:50:21 UTC 2018


ngraham created this revision.
ngraham added a reviewer: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  Horizontal space on the toolbar is precious and scarce, and that Reload button is taking up some of it.
  
  Once there's a Reload button in the context menu, it can probably be safely removed from the toolbar. It's not useful for local views since KDirWatcher updates the view automatically. It //can// be useful for network views, but those are a minority of use cases, and with D12215 <https://phabricator.kde.org/D12215>, it's present in the context menu.
  
  Depends on D12215 <https://phabricator.kde.org/D12215>

TEST PLAN
  Reload button in the context menu, but not the toolbar:

BRANCH
  no-reload-button-in-toolbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12218

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180415/1d45893b/attachment.html>


More information about the Kde-frameworks-devel mailing list