D12130: Use the more user-friendly string "File format" in the save dialogs

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kfilewidget.cpp:1334
> +    QString filterWhatsThisText;
>      if (operationMode == KFileWidget::Saving) {
> +        locationWhatsThisText = "<qt>" + i18n("This is the name to save the file as.") +

I think with an empty line after the QString variable declarations, the 'if' can breathe a bit :)

> kfilewidget.cpp:1338
> +        filterWhatsThisText = i18n("<qt>This is the file type selector. "
> +                         "Use it to choose what format to save the file as.</qt>");
> +        q->setFilterLabel(i18n("&File Format:"));

Do you say "Save a file as a format" or "Save a file in a format"?

> kfilewidget.cpp:1339
> +                         "Use it to choose what format to save the file as.</qt>");
> +        q->setFilterLabel(i18n("&File Format:"));
>      } else if (ops->mode() & KFile::Files) {

It feels odd that the label is changed in this method. I suggest to move it into the function that calls it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12130

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx
Cc: cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180412/6ea8573b/attachment.html>