D12028: taglibextractortest: Add test for files with empty metadata

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Apr 12 17:28:57 UTC 2018


bruns added a comment.


  Untested, but looks good to me otherwise.

INLINE COMMENTS

> taglibextractortest.cpp:42
>  
> +const QStringList TagLibExtractorTest::propertyEnumNames(const QList<KFileMetaData::Property::Property>& keys) const
> +{

Nitpick - needs some indentation

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12028

To: michaelh, mgallien, #baloo, #frameworks
Cc: bruns, astippich, ashaposhnikov, michaelh, spoorun, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180412/76335471/attachment.html>


More information about the Kde-frameworks-devel mailing list