D12145: autotests: Do not use QScopedPointer for plugins
Matthieu Gallien
noreply at phabricator.kde.org
Thu Apr 12 15:57:47 UTC 2018
mgallien added a comment.
In D12145#245023 <https://phabricator.kde.org/D12145#245023>, @alexeymin wrote:
> Just curious, why is this needed? To avoid dynamic memory allocations?
I asked on new code to avoid using an extractor allocated on heap instead of on stack. @michaelh just did the modifications in all tests to keep them coherent.
To me, the allocation on heap looks absolutely overhead.
REPOSITORY
R286 KFileMetaData
BRANCH
plugin-simple (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12145
To: michaelh, #baloo, #frameworks, mgallien, bruns
Cc: alexeymin, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180412/4c575db8/attachment.html>
More information about the Kde-frameworks-devel
mailing list