D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

Nathaniel Graham noreply at phabricator.kde.org
Thu Apr 12 15:20:59 UTC 2018


ngraham created this revision.
ngraham added reviewers: Frameworks, VDG, rkflx.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch improves the grid spacing in icons-on-top mode by making it looser for small icons (which gives the labels more space) and tighter for large icons (which allows more to be seen at once)

TEST PLAN
  Tested with a new user account and default settings. Open Gwenview, Choose File > Open, then Settings button > Icon Position > Above file name
  
  Before, default tiny icons:
  
  After, default tiny icons:
  
  Before: large icons:
  
  After: large icons:
  
  Before: huge icons:
  
  After, huge icons:
  
  Before, resizing:
  
  After: resizing:
  
  Note: the default dialog size is 2 pixels too narrow to properly accomodate an additional row of icons at their largest size both with and without this patch. I'll be submitting another patch to improve that.
  
  No change for any other view modes

REPOSITORY
  R241 KIO

BRANCH
  tighter-grid-in-icons-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12149

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: ngraham, #frameworks, #vdg, rkflx
Cc: michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180412/aa262627/attachment.html>


More information about the Kde-frameworks-devel mailing list